Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "shmget: No space left on device" #424

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix "shmget: No space left on device" #424

wants to merge 3 commits into from

Conversation

andrew-ld
Copy link

Types of changes

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Purpose of changes

fix #423

budtmo
budtmo reviewed May 13, 2024
View reviewed changes
Copy link
Owner

@budtmo budtmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrew-ld ,

thank you for the PR. if I understand correctly, using shm will accelerates the screen reading. I never have issue with the shm on. have you found the root cause on your host machine why it need to be off? because I am not sure if it is a good idea to make it off by default and it might have side affects (mess up with colour etc). instead of making it off by default, I think we can pass additional flag for that through environment variable. what do you think?

@andrew-ld
Copy link
Author

andrew-ld commented May 14, 2024 •
edited
Loading

@budtmo hi, i found the root cause but being on a kubernetes cluster with hundreds of other programs and to solve this problem i would have to change a sysctl that would apply to the whole machine/cluster i decided to find an alternative solution.

Reading the documentation of x11vnc, it seems that the side effects with the use of noshm do not apply to this program/use case.

anyway in any case to resolve any doubts I added an environment variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budtmo budtmo budtmo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug ]: vnc shmget: no space left on device
2 participants
@andrew-ld @budtmo